adutra commented on code in PR #804:
URL: https://github.com/apache/polaris/pull/804#discussion_r1929158600
##########
regtests/run_spark_sql.sh:
##########
@@ -55,7 +55,7 @@ if [ -z "${SPARK_HOME}"]; then
export SPARK_HOME=$(realpath ~/${SPARK_DISTRIBUTION})
fi
-SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN:-principal:root;realm:default-realm}"
+SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN:-principal:root;realm:POLARIS}"
Review Comment:
> do we still need this token default value
Indeed I thought about removing the default values everywhere, but I wasn't
sure whether all these scripts are always executed from the `run.sh`
entrypoint. Do you think we should remove the default values?
> may be we should consider adding code to get a token within this script to
make it work out-of-box.
Good catch! The script is definitely meant to be executed individually. I
will add support for default auth in that script as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
