HonahX commented on code in PR #804:
URL: https://github.com/apache/polaris/pull/804#discussion_r1929184850
##########
regtests/run_spark_sql.sh:
##########
@@ -55,7 +55,7 @@ if [ -z "${SPARK_HOME}"]; then
export SPARK_HOME=$(realpath ~/${SPARK_DISTRIBUTION})
fi
-SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN:-principal:root;realm:default-realm}"
+SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN:-principal:root;realm:POLARIS}"
Review Comment:
> Done, let me know what you think!
Thanks for adding that! Look great!
> but I wasn't sure whether all these scripts are always executed from the
run.sh entrypoint. Do you think we should remove the default values?
My understanding is that the default values will always fail since `default`
authenticator reject `principal:root:realm:*` token anyway. We will need to
either execute `run.sh` to store a real token in env or adding the default auth
like `run_spark_sql.sh` to make scripts able to be executed without `run.sh`.
Keeping default values there will have no affect on tests but I feel it will
cause additional work if we want to change realm name for regression test in
the future. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
