dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1930975445


##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -38,20 +39,37 @@ public class BootstrapCommand extends BaseCommand {
   List<String> realms;
 
   @CommandLine.Option(
-      names = {"-c", "--credential"},
-      paramLabel = "<realm,clientId,clientSecret>",

Review Comment:
   I'm suggesting to delegate the choice of which way to go to the user.
   
   Option 1:
   `bootstrap --realm r1 --client-id c1 --client-secret s1`
   [... do something else ...]
   `bootstrap --realm r2 --client-id c2 --client-secret s2`
   etc....
   
   Option 2:
   `bootstrap --json '{...}'` - here all realm IDs and client ID/secret pairs 
are in the JSON.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to