eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1930999725
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -38,20 +39,37 @@ public class BootstrapCommand extends BaseCommand {
List<String> realms;
@CommandLine.Option(
- names = {"-c", "--credential"},
- paramLabel = "<realm,clientId,clientSecret>",
Review Comment:
`bootstrap --json` feels a little unclear to me; e.g. should the
`--print-credentials` option also go inside that JSON? It seems to imply that
we are bootstrapping in JSON "mode" or providing all options into a JSON. While
in fact, the JSON is just a set of `credentials`.
Since we call it `credentials`, I think having a second way to do the exact
same thing could be confusing, i.e. having both a `credentials` option and a
`client-id` option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
