dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1931087539
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -38,20 +39,37 @@ public class BootstrapCommand extends BaseCommand {
List<String> realms;
@CommandLine.Option(
- names = {"-c", "--credential"},
- paramLabel = "<realm,clientId,clientSecret>",
Review Comment:
`--print-credentials` is just a CLI option. I do no think it should be
inside JSON.
As for `--json` being unclean, how about:
Option 1: `bootstrap --realm ... [ --client-id ... --client-secret ...]` (as
above)
Option 2: `bootstrap --realm-json <json>`, where `<json>` is from from
@adutra 's example
Option 3: `bootstrap --realm-yaml ...` - same as JSON, but in YAML format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
