dimas-b commented on code in PR #899:
URL: https://github.com/apache/polaris/pull/899#discussion_r1932359021
##########
polaris-core/src/main/java/org/apache/polaris/core/context/Realm.java:
##########
@@ -29,16 +29,16 @@
* isolated "universes".
*/
@PolarisImmutable
-@JsonSerialize(as = ImmutableRealmId.class)
-@JsonDeserialize(as = ImmutableRealmId.class)
-public interface RealmId {
+@JsonSerialize(as = ImmutableRealm.class)
+@JsonDeserialize(as = ImmutableRealm.class)
+public interface Realm {
- static RealmId newRealmId(String id) {
- return ImmutableRealmId.of(id);
+ static Realm newRealm(String id) {
Review Comment:
suggestion for the sake of clarity: `forId(String id)` or `fromId(String id)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
