flyrain commented on code in PR #899:
URL: https://github.com/apache/polaris/pull/899#discussion_r1932985386
##########
polaris-core/src/main/java/org/apache/polaris/core/context/Realm.java:
##########
@@ -25,23 +25,23 @@
import org.immutables.value.Value;
/**
- * Represents the ID of the realm used in a REST request associated with
routing to independent and
- * isolated "universes".
+ * Represents an isolated "universe" within the system, such as different
deployments (e.g.,
+ * production, staging, QA) or distinct accounts.
*/
@PolarisImmutable
-@JsonSerialize(as = ImmutableRealmId.class)
-@JsonDeserialize(as = ImmutableRealmId.class)
-public interface RealmId {
+@JsonSerialize(as = ImmutableRealm.class)
+@JsonDeserialize(as = ImmutableRealm.class)
+public interface Realm {
- static RealmId newRealmId(String id) {
- return ImmutableRealmId.of(id);
+ static Realm fromName(String name) {
+ return ImmutableRealm.of(name);
}
- static RealmId copyOf(RealmId realmId) {
- return ImmutableRealmId.copyOf(realmId);
+ static Realm copyOf(Realm realm) {
+ return ImmutableRealm.copyOf(realm);
}
@Value.Parameter
@JsonValue
- String id();
+ String name();
Review Comment:
I think `id` and `name` are almost interchangeable, but I change it to
`name` to be consistent with other entities in Polaris, like `catalog`,
`namespace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
