eric-maynard commented on code in PR #969:
URL: https://github.com/apache/polaris/pull/969#discussion_r1955752599
##########
polaris-core/src/main/resources/schemas/policies/system/metadata-compaction/2025-02-03.json:
##########
@@ -0,0 +1,37 @@
+{
+ "license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/metadata-compaction/2025-02-03.json";,
Review Comment:
Does the JSON magically land at the location specified in the ID somehow? Or
do we always need a followup PR?
Also, it looks a little funny to use dates here given that the date in the
PR may not align with the date the schema actually becomes effective. In the
worst case, we could merge two versions in one day. Maybe just an incrementing
number is easier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
