flyrain commented on code in PR #969:
URL: https://github.com/apache/polaris/pull/969#discussion_r1956515947
##########
polaris-core/src/main/resources/schemas/policies/system/orphan-file-removal/2025-02-03.json:
##########
@@ -0,0 +1,47 @@
+{
+ "license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/orphan-file-removal/2025-02-03.json";,
+ "title": "Orphan File Removal Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table orphan
file removal.",
+ "type": "object",
+ "properties": {
+ "version": {
+ "type": "string",
+ "const": "2025-02-03",
+ "description": "Schema version."
+ },
+ "enable": {
+ "type": "boolean",
+ "description": "Enable or disable orphan file removal."
+ },
+ "max_orphan_file_age_in_days": {
+ "type": "number",
+ "description": "Specifies the maximum age (in days) for orphaned files
before they are eligible for removal."
+ },
+ "location": {
+ "type": "string",
+ "description": "Specifies a custom directory to search for files instead
of the default table location. Use with caution—if set to a broad location
(e.g., s3://my-bucket instead of s3://my-bucket/my-table-location), all
unreferenced files in that path may be permanently deleted, including files
from other tables. Following best practices, tables should be stored in
separate locations to avoid accidental data loss."
Review Comment:
> put line breaks in the string
One of my versions was that :). It didn't help much, esp. in the IDE.
##########
polaris-core/src/main/resources/schemas/policies/system/orphan-file-removal/2025-02-03.json:
##########
@@ -0,0 +1,47 @@
+{
+ "license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/orphan-file-removal/2025-02-03.json";,
+ "title": "Orphan File Removal Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table orphan
file removal.",
+ "type": "object",
+ "properties": {
+ "version": {
+ "type": "string",
+ "const": "2025-02-03",
+ "description": "Schema version."
+ },
+ "enable": {
+ "type": "boolean",
+ "description": "Enable or disable orphan file removal."
+ },
+ "max_orphan_file_age_in_days": {
+ "type": "number",
+ "description": "Specifies the maximum age (in days) for orphaned files
before they are eligible for removal."
+ },
+ "location": {
+ "type": "string",
+ "description": "Specifies a custom directory to search for files instead
of the default table location. Use with caution—if set to a broad location
(e.g., s3://my-bucket instead of s3://my-bucket/my-table-location), all
unreferenced files in that path may be permanently deleted, including files
from other tables. Following best practices, tables should be stored in
separate locations to avoid accidental data loss."
Review Comment:
> put line breaks in the string
One of my versions was that :). It didn't help much, esp. in the IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
