flyrain commented on PR #969: URL: https://github.com/apache/polaris/pull/969#issuecomment-2676335522
Update the doc link. > The changes committed to the production code base are not used, there is just no code that uses those - and won't be used soon. Those belong to a topic that's overall still WIP - hence I object merging it into main at this point. It's a common and recommended way to break a big feature into multiple small PRs, which not only makes the process iterating faster, but also improve review/code quality. A separate branch is only necessary when a feature introduces breaking changes, which is not the case for this PR. > These files land in a place that makes it extremely hard for arbitrary consumers to consume those. I do not think that those should live there. I'm surprised by this claim. It's a common practice to put non-code files in the dir `resources`, it's pretty easy for any Java code to consume. For example, #938 introduced a way to consume these schemas. We also plan to publish them in the website for other tools to consume. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
