omarsmak commented on code in PR #969:
URL: https://github.com/apache/polaris/pull/969#discussion_r1964062880
##########
polaris-core/src/main/resources/schemas/policies/system/orphan-file-removal/2025-02-03.json:
##########
@@ -0,0 +1,50 @@
+{
+ "license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/orphan-file-removal/2025-02-03.json";,
+ "title": "Orphan File Removal Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table orphan
file removal",
+ "type": "object",
+ "properties": {
+ "version": {
+ "type": "string",
+ "const": "2025-02-03",
+ "description": "Schema version"
+ },
+ "enable": {
+ "type": "boolean",
+ "description": "Enable or disable orphan file removal."
+ },
+ "max_orphan_file_age_in_days": {
Review Comment:
@flyrain this also struggles me a bit, remove orphan policy can be even
expressed in more than in just file age. We don't we opt for the `config` key
similar to the other policies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
