dennishuo commented on code in PR #1057:
URL: https://github.com/apache/polaris/pull/1057#discussion_r1968313476
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -51,7 +51,7 @@ public interface FileIOFactory {
* @return a configured FileIO instance.
*/
FileIO loadFileIO(
- @Nonnull RealmContext realmContext,
+ @Nonnull CallContext callContext,
Review Comment:
Yeah it actually is already needed because it uses the
`getOrGenerateSubScopeCreds` which for now is still in the main persistence
interface (it's starting to be separated out via the `PolarisCredentialVendor`
interface, but that still needs more work to fully split, and either way the
Transacting impls need the MetaStoreSession to get the subscoped creds).
So it actually needs *all* of `PolarisCallContext` right now (and before
this PR was accessing it via the ThreadLocal).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
