dimas-b commented on code in PR #1057:
URL: https://github.com/apache/polaris/pull/1057#discussion_r1968327730
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -51,7 +51,7 @@ public interface FileIOFactory {
* @return a configured FileIO instance.
*/
FileIO loadFileIO(
- @Nonnull RealmContext realmContext,
+ @Nonnull CallContext callContext,
Review Comment:
`getOrGenerateSubScopeCreds` is defined in `StorageCredentialCache` not in
`PolarisMetaStoreSession`.
I did not block this PR, but I think this API change is far from ideal.
@dennishuo : would you mind refactoring it some more to reduce the scope of
services exposed to FileIO factories?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
