eric-maynard commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1970981118
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureStorageConfigurationInfo.java:
##########
@@ -19,20 +19,18 @@
package org.apache.polaris.core.storage.azure;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.MoreObjects;
import jakarta.annotation.Nonnull;
import jakarta.annotation.Nullable;
import java.util.List;
import java.util.Objects;
+import org.apache.polaris.core.PolarisConfiguration;
+import org.apache.polaris.core.context.CallContext;
import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
/** Azure storage configuration information. */
public class AzureStorageConfigurationInfo extends
PolarisStorageConfigurationInfo {
- // technically there is no limitation since expectation for Azure locations
are for the same
- // storage account and same container
- @JsonIgnore private static final int MAX_ALLOWED_LOCATIONS = 20;
Review Comment:
My understanding is that currently it's impossible (or very difficult) to
hit a limitation on _any_ of the cloud providers due to the fact that requests
to the subscoping service only pertain to whatever table is being accessed.
In the future, if tables really could have so many locations that these
limits become possible to hit, we may need different limits for different
clouds. But I suspect that we would also need different limits for the number
of locations that a catalog can have vs. the number of locations a table can
have, so those cloud-specific values we might add at that time wouldn't
conflict with the catalog-level config being added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
