flyrain commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1972104200
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,11 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ public static final PolarisConfiguration<Integer>
STORAGE_CONFIGURATION_MAX_LOCATIONS =
+ PolarisConfiguration.<Integer>builder()
+ .key("STORAGE_CONFIGURATION_MAX_LOCATIONS")
+ .description("How many locations can be associated with a storage
configuration")
+ .defaultValue(20)
Review Comment:
Sorry I didn't express it clearly originally. My question is about why we
need a limit on the allowed-locations of a catalog? Per our off-line
discussion, IIUC, it's needed for table level policy used by credential vending
so that the policy text won't be too long to exceed certain limit. Given that
table locations are limited even there could be a large number of
allowed-locations of its catalog, it seems not an issue, and no reason to put a
limit. Am I understanding correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
