flyrain commented on code in PR #1105:
URL: https://github.com/apache/polaris/pull/1105#discussion_r1978380536
##########
service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##########
@@ -166,12 +166,15 @@ public static Collection<String> getAccessDeniedHints() {
static int mapExceptionToResponseCode(RuntimeException rex) {
// Cloud exceptions
Review Comment:
nit: remove this comment as the method name is descriptive
##########
service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##########
@@ -119,7 +119,7 @@ public Response toResponse(RuntimeException
runtimeException) {
* @return whether any throwable in the exception chain
case-insensitive-contains the given
* message
*/
- static boolean doesAnyThrowableContainAccessDeniedHint(Exception e) {
+ static boolean doesAnyThrowableContainAccessDeniedHint(Throwable e) {
Review Comment:
nit: `Throwable e` -> `Throwable t`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
