dennishuo commented on code in PR #1134:
URL: https://github.com/apache/polaris/pull/1134#discussion_r1985941528
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/PolarisMetaStoreManagerImpl.java:
##########
@@ -1980,11 +1983,22 @@ private PolarisEntityResolver
resolveSecurableToRoleGrant(
String.valueOf(
Integer.parseInt(properties.getOrDefault(PolarisTaskConstants.ATTEMPT_COUNT,
"0"))
+ 1));
- task.setEntityVersion(task.getEntityVersion() + 1);
-
task.setProperties(PolarisObjectMapperUtil.serializeProperties(callCtx,
properties));
- ms.writeEntity(callCtx, task, false, originalTask);
+ updatedTask.setProperties(
+ PolarisObjectMapperUtil.serializeProperties(callCtx,
properties));
+ EntityResult result = updateEntityPropertiesIfNotChanged(callCtx,
ms, null, updatedTask);
Review Comment:
Yeah, `loadTasks` probably is just a bad name. It is more correctly
`leaseTasks`. Should I rename in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
