dennishuo commented on code in PR #1134:
URL: https://github.com/apache/polaris/pull/1134#discussion_r1985941988


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/PolarisMetaStoreManagerImpl.java:
##########
@@ -1966,9 +1966,12 @@ private PolarisEntityResolver 
resolveSecurableToRoleGrant(
             },
             Function.identity());
 
+    List<PolarisBaseEntity> loadedTasks = new ArrayList<>();

Review Comment:
   I think @collado-mike had some plans for this. I believe it's what's needed 
next to have better than "best-effort in-memory attempt at cleanup of tables 
after purge".
   
   For now I'm just trying to have the tests passing while implementing the 
NonTransactionalMetaStoreManager that also needs to support `loadTasks` to pass 
the base MetaStoreManager test :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to