metadaddy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1989564301
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -250,6 +268,21 @@ public Builder setStorageConfigurationInfo(
awsConfig.validateArn(awsConfigModel.getRoleArn());
config = awsConfig;
break;
+
+ case S3_COMPATIBLE:
+ S3CompatibleStorageConfigInfo s3ConfigModel =
+ (S3CompatibleStorageConfigInfo) storageConfigModel;
+ config =
+ new S3CompatibleStorageConfigurationInfo(
Review Comment:
Also, Backblaze (only one 'l'! 🙂) B2, and I'm guessing some other
S3-compatible services, doesn't have an STS, so there's no point in specifying
an endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
