omarsmak commented on code in PR #389: URL: https://github.com/apache/polaris/pull/389#discussion_r1989656706
########## helm/polaris/values.yaml: ########## @@ -359,209 +359,76 @@ extraEnv: # name: aws-secret # key: secret_access_key -# -- Extra volumes to add to the polaris pod. See https://kubernetes.io/docs/concepts/storage/volumes/. -extraVolumes: [] - # - name: extra-volume - # emptyDir: {} - -# -- Extra volume mounts to add to the polaris container. See https://kubernetes.io/docs/concepts/storage/volumes/. -extraVolumeMounts: [] - # - name: extra-volume - # mountPath: /usr/share/extra-volume - -# -- Add additional init containers to the polaris pod(s) See https://kubernetes.io/docs/concepts/workloads/pods/init-containers/. -extraInitContainers: [] - # - name: your-image-name - # image: your-image - # imagePullPolicy: Always - # command: ['sh', '-c', 'echo "hello world"'] - -tracing: - # -- Specifies whether tracing for the polaris server should be enabled. - enabled: false - # -- The collector endpoint URL to connect to (required). - # The endpoint URL must have either the http:// or the https:// scheme. - # The collector must talk the OpenTelemetry protocol (OTLP) and the port must be its gRPC port (by default 4317). - # See https://quarkus.io/guides/opentelemetry for more information. - endpoint: "http://otlp-collector:4317"; - # -- Which requests should be sampled. Valid values are: "all", "none", or a ratio between 0.0 and - # "1.0d" (inclusive). E.g. "0.5d" means that 50% of the requests will be sampled. - # Note: avoid entering numbers here, always prefer a string representation of the ratio. - sample: "1.0d" - # -- Resource attributes to identify the polaris service among other tracing sources. - # See https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/#service. - # If left empty, traces will be attached to a service named "Apache Polaris"; to change this, - # provide a service.name attribute here. - attributes: - {} - # service.name: my-polaris - -metrics: - # -- Specifies whether metrics for the polaris server should be enabled. - enabled: true - # -- Additional tags (dimensional labels) to add to the metrics. - tags: - {} - # service: polaris - # environment: production - -serviceMonitor: - # -- Specifies whether a ServiceMonitor for Prometheus operator should be created. - enabled: true - # -- The scrape interval; leave empty to let Prometheus decide. Must be a valid duration, e.g. 1d, 1h30m, 5m, 10s. - interval: "" - # -- Labels for the created ServiceMonitor so that Prometheus operator can properly pick it up. - labels: - {} - # release: prometheus - # -- Relabeling rules to apply to metrics. Ref https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config. - metricRelabelings: [] - # - source_labels: [ __meta_kubernetes_namespace ] - # separator: ; - # regex: (.*) - # target_label: namespace - # replacement: $1 - # action: replace - -# -- Logging configuration. -logging: - # -- The log level of the root category, which is used as the default log level for all categories. - level: INFO - # -- The header name to use for the request ID. - requestIdHeaderName: Polaris-Request-Id - # -- Configuration for the console appender. - console: - # -- Whether to enable the console appender. - enabled: true - # -- The log level of the console appender. - threshold: ALL - # -- Whether to log in JSON format. - json: false - # -- The log format to use. Ignored if JSON format is enabled. See - # https://quarkus.io/guides/logging#logging-format for details. - format: "%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c{3.}] [%X{requestId},%X{realmId}] [%X{traceId},%X{parentId},%X{spanId},%X{sampled}] (%t) %s%e%n" - # -- Configuration for the file appender. - file: - # -- Whether to enable the file appender. - enabled: false - # -- The log level of the file appender. - threshold: ALL - # -- Whether to log in JSON format. - json: false - # -- The log format to use. Ignored if JSON format is enabled. See - # https://quarkus.io/guides/logging#logging-format for details. - format: "%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c{3.}] [%X{requestId},%X{realmId}] [%X{traceId},%X{parentId},%X{spanId},%X{sampled}] (%t) %s%e%n" - # -- The local directory where log files are stored. The persistent volume claim will be mounted - # here. - logsDir: /deployments/logs - # -- The log file name. - fileName: polaris.log - # -- Log rotation configuration. - rotation: - # -- The maximum size of the log file before it is rotated. Should be expressed as a Kubernetes quantity. - maxFileSize: 100Mi - # -- The maximum number of backup files to keep. - maxBackupIndex: 5 - # -- An optional suffix to append to the rotated log files. If present, the rotated log files - # will be grouped in time buckets, and each bucket will contain at most maxBackupIndex files. - # The suffix must be in a date-time format that is understood by DateTimeFormatter. If the - # suffix ends with .gz or .zip, the rotated files will also be compressed using the - # corresponding algorithm. - fileSuffix: ~ # .yyyy-MM-dd.gz - # -- The log storage configuration. A persistent volume claim will be created using these - # settings. - storage: - # -- The storage class name of the persistent volume claim to create. - className: standard - # -- The size of the persistent volume claim to create. - size: 512Gi - # -- Labels to add to the persistent volume claim spec selector; a persistent volume with - # matching labels must exist. Leave empty if using dynamic provisioning. - selectorLabels: {} - # app.kubernetes.io/name: polaris - # app.kubernetes.io/instance: RELEASE-NAME - # -- Configuration for specific log categories. - categories: - org.apache.polaris: INFO - org.apache.iceberg.rest: INFO - # Useful to debug configuration issues: - # io.smallrye.config: DEBUG - # -- Configuration for MDC (Mapped Diagnostic Context). Values specified here will be added to the - # log context of all incoming requests and can be used in log patterns. - mdc: - # aid=polaris - # sid=polaris-service - {} - -# -- Realm context resolver configuration. -realmContext: - # -- The type of realm context resolver to use. Two built-in types are supported: default and test; - # test is not recommended for production as it does not perform any realm validation. - type: default - # -- List of valid realms, for use with the default realm context resolver. The first realm in - # the list is the default realm. Realms not in this list will be rejected. - realms: - - POLARIS - -# -- Polaris features configuration. -features: - # -- Features to enable or disable globally. If a feature is not present in the map, the default - # built-in value is used. - defaults: {} - # ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING: false - # SUPPORTED_CATALOG_STORAGE_TYPES: - # - S3 - # - GCS - # - AZURE - # - FILE - # -- Features to enable or disable per realm. This field is a map of maps. The realm name is the key, and the value is a map of - # feature names to values. If a feature is not present in the map, the default value from the 'defaults' field is used. - realmOverrides: {} - # my-realm: - # ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING: true - -# -- Polaris persistence configuration. -persistence: - # -- The type of persistence to use. Two built-in types are supported: in-memory and eclipse-link. - type: eclipse-link # in-memory - # -- The configuration for the eclipse-link persistence manager. - eclipseLink: - # -- The secret name to pull persistence.xml from. - secret: - # -- The name of the secret to pull persistence.xml from. - # If not provided, the default built-in persistence.xml will be used. This is probably not what you want. - name: ~ - # -- The key in the secret to pull persistence.xml from. - key: persistence.xml - # -- The persistence unit name to use. - persistenceUnit: polaris - -# -- Polaris FileIO configuration. -fileIo: - # -- The type of file IO to use. Two built-in types are supported: default and wasb. The wasb one translates WASB paths to ABFS ones. - type: default - -# -- Storage credentials for the server. If the following properties are unset, default -# credentials will be used, in which case the pod must have the necessary permissions to access the storage. -storage: - # -- The secret to pull storage credentials from. - secret: - # -- The name of the secret to pull storage credentials from. - name: ~ - # -- The key in the secret to pull the AWS access key ID from. Only required when using AWS. - awsAccessKeyId: ~ - # -- The key in the secret to pull the AWS secret access key from. Only required when using AWS. - awsSecretAccessKey: ~ - # -- The key in the secret to pull the GCP token from. Only required when using GCP. - gcpToken: ~ - # -- The key in the secret to pull the GCP token expiration time from. Only required when using GCP. Must be a valid ISO 8601 duration. The default is PT1H (1 hour). - gcpTokenLifespan: ~ - -# -- Polaris authentication configuration. -authentication: - # -- The type of authentication to use. Two built-in types are supported: default and test; - # test is not recommended for production. - authenticator: +# -- Configures whether to enable the bootstrap metastore manager job +bootstrapMetastoreManager: false Review Comment: @lefebsy maybe would be easier if you take the helm stuff outside of this PR and have it as a follow up. Wdyt? (so we don't prolong this PR further :)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
