snazy opened a new pull request, #1215: URL: https://github.com/apache/polaris/pull/1215
This change is required for #1213 From [CI](https://github.com/apache/polaris/actions/runs/13952639581/job/39055890829]: ``` /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:188: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. (baseCatalog instanceof SupportsNamespaces) ? (SupportsNamespaces) baseCatalog : null; ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean '(baseCatalog instanceof SupportsNamespaces supportsNamespaces) ? supportsNamespaces : null;'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:189: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. this.viewCatalog = (baseCatalog instanceof ViewCatalog) ? (ViewCatalog) baseCatalog : null; ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'this.viewCatalog = (baseCatalog instanceof ViewCatalog viewCatalog) ? viewCatalog : null;'? > Task :polaris-service-common:compileJava /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:676: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. if (baseCatalog instanceof BasePolarisCatalog) { ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'if (baseCatalog instanceof BasePolarisCatalog basePolarisCatalog) {'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:899: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. if (baseCatalog instanceof BasePolarisCatalog ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'if (baseCatalog instanceof BasePolarisCatalog basePolarisCatalog'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:900: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. && update instanceof MetadataUpdate.SetLocation) { ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean '&& update instanceof MetadataUpdate.SetLocation setLocation) {'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:1022: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. if (!(baseCatalog instanceof BasePolarisCatalog)) { ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'if (!(baseCatalog instanceof BasePolarisCatalog basePolarisCatalog)) {'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:1039: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. if (!(table instanceof BaseTable)) { ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'if (!(table instanceof BaseTable baseTable)) {'? /home/runner/work/polaris/polaris/service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:1064: error: [PatternMatchingInstanceof] This code can be simplified to use a pattern-matching instanceof. if (singleUpdate instanceof MetadataUpdate.SetLocation) { ^ (see https://errorprone.info/bugpattern/PatternMatchingInstanceof) Did you mean 'if (singleUpdate instanceof MetadataUpdate.SetLocation setLocation) {'? ``` <!-- Possible security vulnerabilities: STOP here and contact [email protected] instead! Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated" Please update this summary field: The summary should cover these topics, if applicable: * the motivation for the change * a description of the status quo, for example the current behavior * the desired behavior * etc PR checklist: - Do a self-review of your code before opening a pull request - Make sure that there's good test coverage for the changes included in this PR - Run tests locally before pushing a PR (./gradlew check) - Code should have comments where applicable. Particularly hard-to-understand areas deserve good in-line documentation. - Include changes and enhancements to the documentation (in site/content/in-dev/unreleased) - For Work In Progress Pull Requests, please use the Draft PR feature. Make sure to add the information BELOW this comment. Everything in this comment will NOT be added to the PR description. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
