snazy commented on code in PR #1215:
URL: https://github.com/apache/polaris/pull/1215#discussion_r2007379032
##########
service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -1019,88 +1016,86 @@ public void commitTransaction(CommitTransactionRequest
commitTransactionRequest)
throw new BadRequestException("Cannot update table on external
catalogs.");
}
- if (!(baseCatalog instanceof BasePolarisCatalog)) {
+ if (baseCatalog instanceof BasePolarisCatalog basePolarisCatalog) {
Review Comment:
Hm, while looking into the config-file approach, I realized that exactly
this pattern is explicitly set to `ERROR`
[here](https://github.com/apache/polaris/blob/1cf9e082e851deaf7e346af0801fa436308734fb/build-logic/src/main/kotlin/polaris-java.gradle.kts#L51)
via #393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
