flyrain commented on code in PR #1229: URL: https://github.com/apache/polaris/pull/1229#discussion_r2010639720
########## tools/varint/build.gradle.kts: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { id("polaris-server") } + +dependencies { + implementation(libs.guava) + + testFixturesApi(libs.assertj.core) +} + +description = "Provides variable length integer encoding" Review Comment: > The goal here is to have one dependency that does not have unnecessary other dependencies, kryo for example comes with a bunch of other dependencies (so "even more jars"). The chance of a downstream project depends only on this module is rare. Otherwise, I'd recommend to contribute the code to the other Apache projects like Apache Common(https://commons.apache.org/). In a lot of real use cases, a downstream project will likely depend on modules like `polaris-core`. Plus, given that this module only depends on `libs.guava`, can we put it in `polaris-core` which has guava already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
