flyrain commented on code in PR #1229: URL: https://github.com/apache/polaris/pull/1229#discussion_r2006475870
########## tools/varint/build.gradle.kts: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { id("polaris-server") } + +dependencies { + implementation(libs.guava) + + testFixturesApi(libs.assertj.core) +} + +description = "Provides variable length integer encoding" Review Comment: Do we need to create a new module for just one class? I'm not against having multiple modules, but I'd like to understand the benefits. My concerns are: 1. Increased Complexity – If we continue this approach, we'll end up with significantly more modules to maintain, which could add overhead. 2. Impact on Downstream Users – More modules mean more dependencies, potentially making it harder for downstream users who will have to manage a lot of Polaris jars, other than just a few of them. Would love to hear the rationale behind this approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
