gh-yzou commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013056368
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1189,6 +1189,20 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
this.tableFileIO = defaultFileIO;
}
+ protected PolarisResolvedPathWrapper getTablePath(TableIdentifier
tableIdentifier) {
Review Comment:
@dennishuo are we saying we want to go back to the idea of reusing the
TABLE_LIKE entity? If that is the case, I think it might be better that we
refactor the TableLikeEntity little bit, as @eric-maynard has mentioned, the
current table like entity have many fields and properties that is not required
by Generic Table, we can have a base TableLikeEntity with just basic fields,
and then have IcebergTableLike and GenericTable to extend the base class. in
the future, if we have DELTA_TABLE, it would be another extended entity with a
new subtype DELTA_TABLE. In that way, i think the whole hierarchy could be much
more clear. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
