gh-yzou commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013060108
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1359,6 +1371,9 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
.setMetadataLocation(newLocation)
.build();
}
+ if (entity.getType() == PolarisEntityType.GENERIC_TABLE) {
Review Comment:
when i was looking at the code, i was thinking why an IcebergTableLikeEntity
would have a type GENERIC_TABLE, so I was basically suggesting to move that
check much early and merge with the getTablePath to keep things more uniform.
However it seems the code is significantly changed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
