singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2059579526
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/models/ModelEntity.java:
##########
@@ -152,8 +152,8 @@ public ModelEntity fromResultSet(ResultSet r) throws
SQLException {
.purgeTimestamp(r.getObject("purge_timestamp", Long.class))
.toPurgeTimestamp(r.getObject("to_purge_timestamp", Long.class))
.lastUpdateTimestamp(r.getObject("last_update_timestamp", Long.class))
- .properties(r.getObject("properties", String.class))
- .internalProperties(r.getObject("internal_properties", String.class))
+ .properties(r.getString("properties"))
+ .internalProperties(r.getString("internal_properties"))
Review Comment:
Yes JSONB extraction fails otherwise for PG, H2 doesn't support JSONB and
hence them the type is text, so we do need it other wise resultSet fails with
type mismatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
