singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2060875984
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,13 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public List<DataSource> dataSources(@All List<InstanceHandle<DataSource>>
dataSources) {
Review Comment:
yes, without this i would expect for Datasource directly I get the issue of
datasource inactive and reg test fail all other ways simply doesn't work :'(
##########
quarkus/service/build.gradle.kts:
##########
@@ -122,6 +123,18 @@ dependencies {
testImplementation(libs.threeten.extra)
testImplementation(libs.hawkular.agent.prometheus.scraper)
+
+ testImplementation(project(":polaris-quarkus-test-commons"))
+ testFixturesApi(enforcedPlatform(libs.quarkus.bom)) {
+ exclude(group = "org.antlr", module = "antlr4-runtime")
+ exclude(group = "org.scala-lang", module = "scala-library")
Review Comment:
I think becuase of the recent Generic Table changes we get these see here
what i get when i remove this
```
> Could not resolve org.antlr:antlr4-runtime:{strictly 4.9.3}.
Required by:
project :polaris-quarkus-spark-tests
> Cannot find a version of 'org.antlr:antlr4-runtime' that satisfies
the version constraints:
Dependency path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'org.antlr:antlr4-runtime:{strictly 4.9.3}'
Constraint path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'io.quarkus.platform:quarkus-bom:3.21.2' (platform-runtime) -->
'org.antlr:antlr4-runtime:4.13.0'
Constraint path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'io.quarkus.platform:quarkus-bom:3.21.2' (enforced-platform-runtime) -->
'org.antlr:antlr4-runtime:4.13.0'
Dependency path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'org.apache.polaris:polaris-tests:0.11.0-beta-incubating-SNAPSHOT'
(runtimeElements) -->
'org.apache.iceberg:iceberg-spark-extensions-3.5_2.12:1.8.1' (runtimeElements)
--> 'org.antlr:antlr4-runtime:4.9.3'
Constraint path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'org.apache.polaris:polaris-tests:0.11.0-beta-incubating-SNAPSHOT'
(runtimeElements) -->
'org.apache.iceberg:iceberg-spark-extensions-3.5_2.12:1.8.1' (runtimeElements)
--> 'org.antlr:antlr4:4.13.0' (runtime) --> 'org.antlr:antlr4-runtime:4.13.0'
Dependency path
'org.apache.polaris:polaris-quarkus-spark-tests:0.11.0-beta-incubating-SNAPSHOT'
--> 'org.apache.polaris:polaris-tests:0.11.0-beta-incubating-SNAPSHOT'
(runtimeElements) --> 'org.apache.spark:spark-sql_2.12:3.5.5' (runtime) -->
'org.apache.spark:spark-catalyst_2.12:3.5.5' (runtime) -->
'org.apache.spark:spark-sql-api_2.12:3.5.5' (runtime) -->
'org.antlr:antlr4-runtime:4.9.3'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
