singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2060967933
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,13 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public List<DataSource> dataSources(@All List<InstanceHandle<DataSource>>
dataSources) {
Review Comment:
we do have Pre-Conditions to fail on more than, in the intializeRealm.
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,13 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public List<DataSource> dataSources(@All List<InstanceHandle<DataSource>>
dataSources) {
Review Comment:
yes but if i do that it fails with
https://github.com/apache/polaris/pull/1371#discussion_r2047793303, thats why i
had to move to Instance<> in Quarkus, so one datasource wouldn't work, never
the less we do wanna fix this ASAP and have multiple datasources as an
immediate follow-up
we do have Pre-Conditions to fail on more than, in the intializeRealm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
