dimas-b commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2060976784
##########
quarkus/service/build.gradle.kts:
##########
@@ -122,6 +123,18 @@ dependencies {
testImplementation(libs.threeten.extra)
testImplementation(libs.hawkular.agent.prometheus.scraper)
+
+ testImplementation(project(":polaris-quarkus-test-commons"))
+ testFixturesApi(enforcedPlatform(libs.quarkus.bom)) {
+ exclude(group = "org.antlr", module = "antlr4-runtime")
+ exclude(group = "org.scala-lang", module = "scala-library")
+ exclude(group = "org.scala-lang", module = "scala-reflect")
+ }
+ testFixturesApi("io.quarkus:quarkus-junit5")
+ testFixturesApi(platform(libs.testcontainers.bom))
+ testFixturesApi("org.testcontainers:testcontainers")
+ testFixturesApi("org.testcontainers:postgresql")
+ testFixturesApi("org.postgresql:postgresql")
Review Comment:
I double these test dependencies should be in the "api" scope. They are not
dependencies of the API of this module's test fixtures. Would simple
`testImplementation` be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
