singhpk234 commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2064062351
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public JdbcDatasource jdbcDatasource(@ConfigProperty(name =
"polaris.persistence.realm.isolation.type") String realmIsolationType, @All
List<InstanceHandle<DataSource>> dataSources) {
Review Comment:
Are you suggesting if <realm-id> specific custom DS is there then use realm
specific DS or otherwise use the default one if not there, would it not create
a confusion if there are both ?
For example :
consider realm1, realm2 ....
and the admin configure
``` java
Map.entry("quarkus.datasource.realm1.db-kind", "pgsql"),
Map.entry("quarkus.datasource.realm1.active", "true"),
Map.entry("quarkus.datasource.realm1.jdbc.url",
postgres.getJdbcUrl()),
Map.entry("quarkus.datasource.realm1.username",
postgres.getUsername()),
Map.entry("quarkus.datasource.realm1.password",
postgres.getPassword()),
Map.entry("quarkus.datasource.db-kind", "pgsql"),
Map.entry("quarkus.datasource.jdbc.url",
postgres.getJdbcUrl()),
Map.entry("quarkus.datasource.username",
postgres.getUsername()),
Map.entry("quarkus.datasource.password",
postgres.getPassword()),
```
do we silently make the realm1 go to realm1 DS and realm2 to default DS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
