dimas-b commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2064372190
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public JdbcDatasource jdbcDatasource(@ConfigProperty(name =
"polaris.persistence.realm.isolation.type") String realmIsolationType, @All
List<InstanceHandle<DataSource>> dataSources) {
Review Comment:
What I mean is that the list of realms is restricted by
`RealmContextConfiguration` right now.
Since we have a fixed list of realm IDs, we can have a fixed map realm ID ->
DS name, e.g.
```
quarkus.datasource.dsA.jdbc.url=...
quarkus.datasource.dsB.jdbc.url=...
```
then
```
polaris.realm-contex.data-source.realm1=dsA
polaris.realm-contex.data-source.realm2=dsA
polaris.realm-contex.data-source.realm3=dsB
```
It's up to the Polaris Admin to provide this mapping. The default would be
to map all realms to the "default" DS.
In java:
```
public interface RealmContextConfiguration {
Map<String, String> dataSource();
[...]
}
No other config is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
