fabio-rizzo-01 commented on PR #1596: URL: https://github.com/apache/polaris/pull/1596#issuecomment-2890112910
> Personally I'm fine with you not using `@PolarisImmutable` -- I still haven't figured out why we need that or why my IDE so often doesn't seem to like it: <img alt="Screenshot 2025-05-16 at 10 34 35 AM" width="400" src="https://private-user-images.githubusercontent.com/23219656/444646842-7ccb63af-444b-4905-9006-0a1a7e182f23.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDc2NDE4NTEsIm5iZiI6MTc0NzY0MTU1MSwicGF0aCI6Ii8yMzIxOTY1Ni80NDQ2NDY4NDItN2NjYjYzYWYtNDQ0Yi00OTA1LTkwMDYtMGExYTdlMTgyZjIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTE5VDA3NTkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyYzcyZTk2MTVlZGRkMWFlMWQ3ODY5YzIxOTkzYzc0MWE1YmQ5YzIzYmI5YjZhZGRhZmFhMTZlMmZhNWRmMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yWFixkYh7kh0Zq_wFLLx7BJ2_AXwk23FNim4 a2Xzkvw"> > > But I do think this PR makes quite a few changes, such as those to `TransactionalMetaStoreManagerImpl.java`, which could be reduced or elimated. For example, does the method `setGrantRecordsVersion` really need to go away? If it does, can we implement a cloning method like `withGrantRecordsVersion`? The builder in the PolarisBaseEntity has a constructor that allows you to pass an entity into it, that is what I'm using in`TransactionalMetaStoreManagerImpl.java` to update properties and the grant record version. Like here https://github.com/apache/polaris/pull/1596/files#diff-5327c1f118c61e497b4fb5b3200002388a3a4bcde3b44d91403d202bac6a0cccR293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
