fabio-rizzo-01 commented on PR #1596: URL: https://github.com/apache/polaris/pull/1596#issuecomment-2898416246
> @fabio-rizzo-01 the example you gave is a good one; my point is you could reduce that change to only this line: > > ``` > securableEntity.setGrantRecordsVersion(securableEntity.getGrantRecordsVersion() + 1); > ``` > > Which could become like: > > ``` > securableEntity = securableEntity.withGrantRecordsVersion(securableEntity.getGrantRecordsVersion() + 1) > ``` > > (Or we could make `securableEntity` final and make a new variable, but the code change required to 'update' `grantRecordsVersion` remains smaller) that makes sense, I'll wait for the others to answer my previous question before I'll make the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
