adnanhemani commented on code in PR #1765:
URL: https://github.com/apache/polaris/pull/1765#discussion_r2139319424
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -100,7 +101,12 @@ private void initializeForRealm(
final StoreType backingStore = createBackingStore(diagnostics);
sessionSupplierMap.put(
realmContext.getRealmIdentifier(),
- () -> createMetaStoreSession(backingStore, realmContext,
rootCredentialsSet, diagnostics));
+ new CachedSupplier<>(
Review Comment:
This is a good point. This makes me wonder - would my original idea of
materializing the `RealmContext` prior to the creation of the Supplier also
become an issue? For instance, would it be possible that the `RealmContext` is
also be computed lazily in some instances?
Let me follow up with @collado-mike and @dennishuo on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
