collado-mike commented on code in PR #1765:
URL: https://github.com/apache/polaris/pull/1765#discussion_r2151060420
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -100,7 +101,12 @@ private void initializeForRealm(
final StoreType backingStore = createBackingStore(diagnostics);
sessionSupplierMap.put(
realmContext.getRealmIdentifier(),
- () -> createMetaStoreSession(backingStore, realmContext,
rootCredentialsSet, diagnostics));
+ new CachedSupplier<>(
Review Comment:
Yeah, each instance of the session was intended to be scoped to a single
request. Though, it seems now that all the current implementations are
stateless, but the `TransactionalPersistence` interface methods kind of imply a
stateful implementation - e.g., `lookupEntityInCurrentTxn` assumes that there
is a current transaction that has already been started and will be committed at
some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
