gh-yzou commented on code in PR #1857:
URL: https://github.com/apache/polaris/pull/1857#discussion_r2141199644
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -178,3 +178,5 @@ tasks.register<ShadowJar>("createPolarisSparkJar") {
}
tasks.withType(Jar::class).named("sourcesJar") {
dependsOn("createPolarisSparkJar") }
+
+tasks.named<Jar>("jar") { archiveClassifier.set("defaultJar") }
Review Comment:
I tried that before, however, it seems the task `test` depends on the jar
job in the default configuration. i tried to switch the `test` task to depends
on the createPolarisSparkJar, but because that jar job did a relocation of
module com.fasterxml, one of our test fails the deserialization test, because
it is now looking for the shaded one, not the original one.
So far I haven't found a good solution yet, so I kept the original jar.
wondering if you got some better solutions for this problem?
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,7 +151,7 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = "bundle"
+ archiveClassifier = null
Review Comment:
Oh, sorry, we don't have to, the default is null. i was putting it there to
be clear, and I can remove it if preferred, but I think it might be better to
be more explicit in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
