dimas-b commented on code in PR #1857:
URL: https://github.com/apache/polaris/pull/1857#discussion_r2141250742


##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,7 +151,7 @@ tasks.register("checkNoDisallowedImports") {
 tasks.named("check") { dependsOn("checkNoDisallowedImports") }
 
 tasks.register<ShadowJar>("createPolarisSparkJar") {
-  archiveClassifier = "bundle"
+  archiveClassifier = null

Review Comment:
   From my POV removing the assignment is preferable since the value is the 
same as default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to