pavibhai commented on code in PR #1932:
URL: https://github.com/apache/polaris/pull/1932#discussion_r2173831605


##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/S3Location.java:
##########


Review Comment:
   Added this



##########
polaris-core/src/test/java/org/apache/polaris/service/storage/StorageLocationTest.java:
##########
@@ -77,4 +81,12 @@ public void testSpecialCharacters() {
             })
         .hasCauseInstanceOf(URISyntaxException.class);
   }
+
+  @ParameterizedTest
+  @CsvSource({"s3,s3a", "s3a,s3"})
+  public void testPrefixValidationIgnoresScheme(String parentScheme, String 
childScheme) {

Review Comment:
   Moved this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to