pavibhai commented on code in PR #1932:
URL: https://github.com/apache/polaris/pull/1932#discussion_r2173832564
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java:
##########
@@ -79,7 +80,7 @@ public void testGetSubscopedCreds() {
.returns(roleARN, AssumeRoleRequest::roleArn);
return ASSUME_ROLE_RESPONSE;
});
- String warehouseDir = "s3://bucket/path/to/warehouse";
+ String warehouseDir = scheme + "://bucket/path/to/warehouse";
Review Comment:
> Can we test the mixed use cases? For example, we create a catalog with
allowed locations like `s3://bucket1/abc/`, while some of tables paths are with
`s3a`. Does credential vending work in that case? Also i'm not sure how much
this simulation can catch. It'd be nice to have a test against the real s3
storage for the mixed use cases.
These tests have been moved to `PolarisS3InterOperabilityTest`, please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
