HonahX commented on PR #1986: URL: https://github.com/apache/polaris/pull/1986#issuecomment-3029755625
Thanks for the example PR! Sorry I missed the discussion earlier, just want to understand more about the motivation behind this. Do we want to add python format check to gradle because we want format issue stops CI before enterring the real test cases? Currently the python workflow can do that via the `lint` step, which is before the unit and integration tests https://github.com/apache/polaris/blob/b0c85e39f6ec3d50ff65f689628611d68723f3cd/.github/workflows/python-client.yml#L70-L73 IMHO, the python client should be isolated from the main java project and all the dependency management/test/checking should happen with in that folder via poetry and some other python specific tools. And format failure or test failure should not cause irrelevant CI workflow to fail (e.g. Java Gradle test). This could help make it simpler to maintain python and outer java project. We do have open api client generation configured in gradle now for existing quickstart and regtest, but I hope we could make that automated during package installation: https://github.com/apache/polaris/pull/1885 But please let me know if I miss anything or if there are other good thing about gradle python format check : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
