adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182086669
##########
helm/polaris/README.md:
##########
@@ -335,13 +335,20 @@ ct install --namespace polaris --debug --charts
./helm/polaris \
| metrics.enabled | bool | `true` | Specifies whether metrics for the polaris
server should be enabled. |
| metrics.tags | object | `{}` | Additional tags (dimensional labels) to add
to the metrics. |
| nodeSelector | object | `{}` | Node labels which must match for the polaris
pod to be scheduled on that node. See
https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector.
|
-| persistence | object |
`{"eclipseLink":{"persistenceUnit":"polaris","secret":{"key":"persistence.xml","name":null}},"type":"eclipse-link"}`
| Polaris persistence configuration. |
+| persistence | object |
`{"eclipseLink":{"persistenceUnit":"polaris","secret":{"key":"persistence.xml","name":null}},"relationalJdbc":{"dbKind":"postgres","secret":{"jdbcUrl":null,"name":null,"password":null,"username":null}},"type":"eclipse-link"}`
| Polaris persistence configuration. |
| persistence.eclipseLink | object |
`{"persistenceUnit":"polaris","secret":{"key":"persistence.xml","name":null}}`
| The configuration for the eclipse-link persistence manager. |
| persistence.eclipseLink.persistenceUnit | string | `"polaris"` | The
persistence unit name to use. |
| persistence.eclipseLink.secret | object |
`{"key":"persistence.xml","name":null}` | The secret name to pull
persistence.xml from. |
| persistence.eclipseLink.secret.key | string | `"persistence.xml"` | The key
in the secret to pull persistence.xml from. |
| persistence.eclipseLink.secret.name | string | `nil` | The name of the
secret to pull persistence.xml from. If not provided, the default built-in
persistence.xml will be used. This is probably not what you want. |
-| persistence.type | string | `"eclipse-link"` | The type of persistence to
use. Two built-in types are supported: in-memory and eclipse-link. |
+| persistence.relationalJdbc | object |
`{"dbKind":"postgres","secret":{"jdbcUrl":null,"name":null,"password":null,"username":null}}`
| The configuration for the relational-jdbc persistence manager. |
+| persistence.relationalJdbc.dbKind | string | `"postgres"` | The database
type to use. Supported values: postgres, h2. |
Review Comment:
Why is dbKind still present? I thought we agreed to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
