adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182103365
##########
helm/polaris/values.yaml:
##########
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
secret:
- # -- The secret name to pull the database connection properties from.
+ # -- The secret name to pull database connection properties from
name: ~
+ # -- The secret key holding the database username for authentication
+ username: ~
Review Comment:
One last remark: I think it could be more user friendly to provide default
key names for each secret key, wdyt? We do this for the EclipseLink secret but
not for the storage secret. But I don't see a good reason not to do it: IOW,
"convention over configuration" 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
