dimas-b commented on code in PR #2445:
URL: https://github.com/apache/polaris/pull/2445#discussion_r2298277088
##########
runtime/service/src/main/java/org/apache/polaris/service/metrics/MetricsConfiguration.java:
##########
@@ -65,4 +68,17 @@ interface RealmIdTag {
@Min(1)
int httpMetricsMaxCardinality();
}
+
+ interface UserPrincipalTag {
+
+ /**
+ * Whether to include the User Principal tag in the API request metrics.
+ *
+ * <p>Beware that if the cardinality of this tag is too high, it can cause
performance issues or
+ * even crash the server.
+ */
+ @WithDefault("false")
+ boolean enableInApiMetrics();
Review Comment:
Defaulting to `false` here looks reasonable to me. Still, since this may
expose sensitive information, please open a `dev` email discussion for
visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
