fivetran-kostaszoumpatianos commented on code in PR #2445:
URL: https://github.com/apache/polaris/pull/2445#discussion_r2301727136
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -113,6 +114,17 @@ public void warnOnFailedChecks(
}
}
+ @Produces
+ public ProductionReadinessCheck checkMetricTags(MetricsConfiguration config)
{
+ if (config.userPrincipalTag().enableInApiMetrics()) {
+ return ProductionReadinessCheck.of(
+ Error.of(
+ "Metrics configuration includes user principal name in tags.",
Review Comment:
Yes, I agree. We should have that at some point. In the interim we could get
away with just having the warning there. I can open an issue and work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
