fivetran-kostaszoumpatianos commented on code in PR #2445:
URL: https://github.com/apache/polaris/pull/2445#discussion_r2309155710
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -113,6 +114,17 @@ public void warnOnFailedChecks(
}
}
+ @Produces
+ public ProductionReadinessCheck checkMetricTags(MetricsConfiguration config)
{
+ if (config.userPrincipalTag().enableInApiMetrics()) {
+ return ProductionReadinessCheck.of(
+ Error.of(
+ "Metrics configuration includes user principal name in tags.",
Review Comment:
@dimas-b
For selectively turning off readiness checks specific to a given list of
offending parameters, I created an issue:
https://github.com/apache/polaris/issues/2471 and an associated PR:
https://github.com/apache/polaris/pull/2472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
