binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315532492
########## persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql: ########## @@ -63,6 +63,9 @@ CREATE INDEX IF NOT EXISTS idx_locations ON entities(realm_id, catalog_id, locat -- TODO: create indexes based on all query pattern. CREATE INDEX IF NOT EXISTS idx_entities ON entities (realm_id, catalog_id, id); +CREATE INDEX IF NOT EXISTS idx_entities_lookup + ON entities (realm_id, catalog_id, parent_id, type_code, sub_type_code) + INCLUDE (id, name); Review Comment: CI tests already failed and I removed INCLUDE instruction. I have put `id, name` under the main brackets `ON (...)`. My bad, I misunderstood the doc - https://www.h2database.com/html/commands.html#create_index. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
