binarycat0 commented on code in PR #2465:
URL: https://github.com/apache/polaris/pull/2465#discussion_r2315603528
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -421,38 +422,13 @@ public List<PolarisChangeTrackingVersions>
lookupEntityVersions(
.collect(Collectors.toList());
}
- @Nonnull
- @Override
- public Page<EntityNameLookupRecord> listEntities(
- @Nonnull PolarisCallContext callCtx,
- long catalogId,
- long parentId,
- @Nonnull PolarisEntityType entityType,
- @Nonnull PolarisEntitySubType entitySubType,
- @Nonnull PageToken pageToken) {
- // TODO: only fetch the properties required for creating an
EntityNameLookupRecord
- return loadEntities(
- callCtx,
- catalogId,
- parentId,
- entityType,
- entitySubType,
- entity -> true,
- EntityNameLookupRecord::new,
- pageToken);
- }
-
- @Nonnull
- @Override
- public <T> Page<T> loadEntities(
- @Nonnull PolarisCallContext callCtx,
+ private PreparedQuery buildEntityQuery(
Review Comment:
Definitely It can be, but it would require extend method signature due to
using `this.realmId` in method. I believe it can be refactored in future when
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
