dimas-b commented on code in PR #2472:
URL: https://github.com/apache/polaris/pull/2472#discussion_r2331429047
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -74,7 +74,14 @@ public void warnOnFailedChecks(
@Observes Startup event,
Instance<ProductionReadinessCheck> checks,
ReadinessConfiguration config) {
- List<Error> errors = checks.stream().flatMap(check ->
check.getErrors().stream()).toList();
+ List<Error> errors =
+ checks.stream()
+ .flatMap(check -> check.getErrors().stream())
+ .filter(
+ error ->
+ config.ignoreOffendingProperties().stream()
+ .noneMatch(prop ->
prop.equalsIgnoreCase(error.offendingProperty())))
Review Comment:
from my POV, this is not so much about config `A=X` or `A=Y`, but more about
"Polaris detected something dangerous about X". Now, if the admin user
suppresses this warning, I do not want the suppression to automatically hide
future warnings about "dangerous Y".
It may be related to some specific config, but may be not. I can imagine
running as the `root` OS user falls under the same category of auto-detectable
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
