dimas-b commented on code in PR #2472:
URL: https://github.com/apache/polaris/pull/2472#discussion_r2345535100
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -74,7 +74,14 @@ public void warnOnFailedChecks(
@Observes Startup event,
Instance<ProductionReadinessCheck> checks,
ReadinessConfiguration config) {
- List<Error> errors = checks.stream().flatMap(check ->
check.getErrors().stream()).toList();
+ List<Error> errors =
+ checks.stream()
+ .flatMap(check -> check.getErrors().stream())
+ .filter(
+ error ->
+ config.ignoreOffendingProperties().stream()
+ .noneMatch(prop ->
prop.equalsIgnoreCase(error.offendingProperty())))
Review Comment:
I'd be ok without the parameter hash for a start. However, having a concise
but non-predictable error ID is important I think. That is to say, a user
suppressing a particular error must first observe the error. It should not be
easy to suppress something "proactively" :) At the same time the error ID
should not be dependent on the runtime env. (i.e. be the same in all k8s pods,
for example). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
